linux-kernel - RE: [patch v2] dca: remove unneeded NULL check

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <129600E5E5FB004392DDC3FB599660D70104DAF162@irsmsx504.ger.corp.intel.com>
Date:	Mon, 22 Nov 2010 16:49:45 +0000
From:	"Sosnowski, Maciej" <maciej.sosnowski@...el.com>
To:	Dan Carpenter <error27@...il.com>,
	Andrew Morton <akpm@...ux-foundation.org>
CC:	"David S. Miller" <davem@...emloft.net>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: RE: [patch v2] dca: remove unneeded NULL check

Dan Carpenter wrote:
> The return here doesn't release the locks or re-enable IRQs.  But as
> Andrew Morton points out, domain is never NULL.  list_first_entry()
> essentially never returns NULL and also we already verified that the
> list is not empty.
> 
> Signed-off-by: Dan Carpenter <error27@...il.com>
> 
> diff --git a/drivers/dca/dca-core.c b/drivers/dca/dca-core.c index
> b98c676..c461eda 100644
> --- a/drivers/dca/dca-core.c
> +++ b/drivers/dca/dca-core.c
> @@ -110,8 +110,6 @@ static void unregister_dca_providers(void)
> 
>  	/* at this point only one domain in the list is expected */
>  	domain = list_first_entry(&dca_domains, struct dca_domain, node);
> -	if (!domain)
> -		return;
> 
>  	list_for_each_entry_safe(dca, _dca, &domain->dca_providers, node) {
>  		list_del(&dca->node);

Acked-by: Maciej Sosnowski <maciej.sosnowski@...el.com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/