linux-kernel - Re: [RFC][PATCH] perf: Tracepoint collection support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 22 Nov 2010 18:17:42 +0100
From:	Peter Zijlstra <peterz@...radead.org>
To:	Ingo Molnar <mingo@...e.hu>
Cc:	tglx <tglx@...utronix.de>, Steven Rostedt <rostedt@...dmis.org>,
	fweisbec <fweisbec@...il.com>,
	Stephane Eranian <eranian@...gle.com>,
	paulus <paulus@...ba.org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [RFC][PATCH] perf: Tracepoint collection support

On Mon, 2010-11-22 at 18:08 +0100, Peter Zijlstra wrote:
> +       if (event->attr.config != ~0ULL) {
> +               err = __perf_event_add_tp(event, event->attr.config);
> +               if (err)
> +                       return err;
> +               err = perf_trace_init(event, event->attr.config);
> +               if (err)
> +                       return err;
> +       } 

That's a double perf_trace_init() call, __perf_event_add_tp() already
does that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/