linux-kernel - Re: [PATCH v7 3/3] nl80211/mac80211: Report signal average

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101122184633.GD2117@tuxdriver.com>
Date:	Mon, 22 Nov 2010 13:46:34 -0500
From:	"John W. Linville" <linville@...driver.com>
To:	Johannes Berg <johannes@...solutions.net>
Cc:	Jouni Malinen <j@...fi>, Bruno Randolf <br1@...fach.org>,
	randy.dunlap@...cle.com, br1@...nktube.com, peterz@...radead.org,
	blp@...stanford.edu, linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org, Lars_Ericsson@...ia.com,
	stefanr@...6.in-berlin.de, kosaki.motohiro@...fujitsu.com,
	akpm@...ux-foundation.org, kevin.granade@...il.com
Subject: Re: [PATCH v7 3/3] nl80211/mac80211: Report signal average

On Fri, Nov 19, 2010 at 10:58:36AM -0800, Johannes Berg wrote:
> On Tue, 2010-11-16 at 11:37 +0200, Jouni Malinen wrote:
> > On Fri, Nov 12, 2010 at 12:00:35PM +0900, Bruno Randolf wrote:
> > > Extend nl80211 to report an exponential weighted moving average (EWMA) of the
> > > signal value. Since the signal value usually fluctuates between different
> > > packets, an average can be more useful than the value of the last packet.
> > > 
> > > This uses the recently added generic EWMA library function.
> > 
> > Isn't that generic EWMA library function making this much more CPU
> > intensive than necessary?
> 
> John, is there any reason you completely ignored Jouni's feedback here?
> This wasn't addressed in v8.

Well, I confess that I didn't fully appreciate Jouni's point.

Is there any reason to presume that Bruno cannot (or will not) improve
the performance from here?  Do you have any measurement of the actual
performance impact?

John
-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/