linux-kernel - Re: Bcache version 9

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101122010914.GB7688@kroah.com>
Date:	Sun, 21 Nov 2010 17:09:14 -0800
From:	Greg KH <greg@...ah.com>
To:	Kent Overstreet <kent.overstreet@...il.com>
Cc:	linux-bcache@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org
Subject: Re: Bcache version 9

On Sun, Nov 21, 2010 at 06:09:34AM -0800, Kent Overstreet wrote:
> +++ b/Documentation/bcache.txt

For new sysfs files, please create Documentation/ABI files.

> +All configuration is done via sysfs. To use sde to cache md1, assuming the
> +SSD's erase block size is 128k:
> +
> +  make-bcache -b128k /dev/sde
> +  echo "/dev/sde" > /sys/kernel/bcache/register_cache
> +  echo "<UUID> /dev/md1" > /sys/kernel/bcache/register_dev

/sys/kernel/bcache/?  Really?

Come on, shouldn't this be somewhere else?  You only have 1 file here,
right?

Shouldn't it be a configfs file instead as that is what you are doing?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/