linux-kernel - Re: [PATCH] dmar: use function stubs when CONFIG_INTR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTin7Jynhdsd07JHHeaq34Nn_FMp6w4QWKwymNktc@mail.gmail.com>
Date:	Mon, 22 Nov 2010 22:36:51 +0100
From:	Fabio Comolli <fabio.comolli@...il.com>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...hat.com>,
	"H. Peter Anvin" <hpa@...or.com>, x86@...nel.org,
	Suresh Siddha <suresh.b.siddha@...el.com>,
	Yinghai Lu <yinghai@...nel.org>
Subject: Re: [PATCH] dmar: use function stubs when CONFIG_INTR_REMAP is disabled

Reported-and-Tested-by: Fabio Comolli <fabio.comolli@...il.com>

On Mon, Nov 22, 2010 at 9:48 PM, Randy Dunlap <randy.dunlap@...cle.com> wrote:
> From: Randy Dunlap <randy.dunlap@...cle.com>
>
> The stubs for CONFIG_INTR_REMAP disabled need to be functions
> instead of values to eliminate build warnings.
>
> arch/x86/kernel/apic/apic.c: In function 'lapic_suspend':
> arch/x86/kernel/apic/apic.c:2060:3: warning: statement with no effect
> arch/x86/kernel/apic/apic.c: In function 'lapic_resume':
> arch/x86/kernel/apic/apic.c:2137:3: warning: statement with no effect
>
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> Reported-by: Fabio Comolli <fabio.comolli@...il.com>
> ---
>  include/linux/dmar.h |   17 ++++++++++++++---
>  1 file changed, 14 insertions(+), 3 deletions(-)
>
> --- lnx-2637-rc3.orig/include/linux/dmar.h
> +++ lnx-2637-rc3/include/linux/dmar.h
> @@ -175,10 +175,21 @@ static inline int set_msi_sid(struct irt
>        return 0;
>  }
>
> -#define enable_intr_remapping(mode)    (-1)
> -#define disable_intr_remapping()       (0)
> -#define reenable_intr_remapping(mode)  (0)
>  #define intr_remapping_enabled         (0)
> +
> +static inline int enable_intr_remapping(int eim)
> +{
> +       return -1;
> +}
> +
> +static inline void disable_intr_remapping(void)
> +{
> +}
> +
> +static inline int reenable_intr_remapping(int eim)
> +{
> +       return 0;
> +}
>  #endif
>
>  /* Can't use the common MSI interrupt functions
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/