linux-kernel - Re: [PATCH] romfs: have romfs_fs.h pull in necessary headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101122135855.6825700d.akpm@linux-foundation.org>
Date:	Mon, 22 Nov 2010 13:58:55 -0800
From:	Andrew Morton <akpm@...ux-foundation.org>
To:	Mike Frysinger <vapier@...too.org>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] romfs: have romfs_fs.h pull in necessary headers

On Sun, 21 Nov 2010 19:24:21 -0500
Mike Frysinger <vapier@...too.org> wrote:

> This header uses things like __be32, so pull in linux/types.h.
> 
> Further, it uses BLOCK_SIZE, so pull in linux/fs.h.
> 
> Signed-off-by: Mike Frysinger <vapier@...too.org>
> ---
>  include/linux/romfs_fs.h |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/include/linux/romfs_fs.h b/include/linux/romfs_fs.h
> index c490fbc..5f57f93 100644
> --- a/include/linux/romfs_fs.h
> +++ b/include/linux/romfs_fs.h
> @@ -1,6 +1,9 @@
>  #ifndef __LINUX_ROMFS_FS_H
>  #define __LINUX_ROMFS_FS_H
>  
> +#include <linux/types.h>
> +#include <linux/fs.h>
> +
>  /* The basic structures of the romfs filesystem */
>  
>  #define ROMBSIZE BLOCK_SIZE

Better changelogs please.

Does this fix any build error?  If so, is that build error present in
2.6.36 or earlier?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/