linux-kernel - Re: Linux 2.6.37-rc3 (fixmap build error)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=4scuTeRyr1WuGbzk2jKdU_Ugu61ABoXPuXnVK@mail.gmail.com>
Date:	Sun, 21 Nov 2010 20:33:07 -0800
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
Cc:	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: Linux 2.6.37-rc3 (fixmap build error)

On Sun, Nov 21, 2010 at 6:16 PM, Randy Dunlap <randy.dunlap@...cle.com> wrote:
>
> I thought that I saw a patch for this one, but I can't find it now.
>
> on i386:
> arch/x86/built-in.o: In function `fix_to_virt':
> /usr/builds/linux-2.6.37-rc3/arch/x86/include/asm/fixmap.h:207: undefined reference to `__this_fixmap_does_not_exist'

Hmm. Does it help to mark __set_fixmap_offset() as "__always_inline"
rather than just "inline"?

Every single "fix_to_virt()" user _should_ use a constant index and
that thing should be inlined and the __this_fixmap_does_not_exist case
should be trivially optimized away.

But if __set_fixmap_offset() doesn't get inlined...

                Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/