linux-kernel - Re: [PATCH] xen/events: Use PIRQ instead of GSI value when unmapping MSI/MSI-X irqs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1011231236210.2373@kaball-desktop>
Date:	Tue, 23 Nov 2010 12:36:39 +0000
From:	Stefano Stabellini <stefano.stabellini@...citrix.com>
To:	Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
CC:	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Stefano Stabellini <Stefano.Stabellini@...citrix.com>,
	Jeremy Fitzhardinge <Jeremy.Fitzhardinge@...rix.com>,
	"xen-devel@...ts.xensource.com" <xen-devel@...ts.xensource.com>
Subject: Re: [PATCH] xen/events: Use PIRQ instead of GSI value when unmapping
 MSI/MSI-X irqs.

On Fri, 19 Nov 2010, Konrad Rzeszutek Wilk wrote:
> When we allocate a vector for MSI/MSI-X we save away the PIRQ, and the
> vector value. When we unmap (de-allocate) the MSI/MSI-X vector(s) we
> need to provide the PIRQ and the vector value. What we did instead
> was to provide the GSI (which was zero) and the vector value, and we
> got these unhappy error messages:
> 
> (XEN) irq.c:1575: dom0: pirq 0 not mapped
> [    7.733415] unmap irq failed -22
> 
> This patches fixes this and we use the PIRQ value instead of the GSI
> value.
> 
> CC: Stefano Stabellini <stefano.stabellini@...citrix.com>
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@...cle.com>
> 
> P.S.
> Stefano, I've tested this on domain zero. The path on PVonHVM looks correct,
> but I would appreciate you taking a look at this.

Acked-by: Stefano Stabellini <stefano.stabellini@...citrix.com>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/