linux-kernel - Re: [tip:sched/core] cpu: Remove incorrect BUG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1290524704.2072.412.camel@laptop>
Date:	Tue, 23 Nov 2010 16:05:04 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Oleg Nesterov <oleg@...hat.com>
Cc:	linux-tip-commits@...r.kernel.org, linux-kernel@...r.kernel.org,
	hpa@...or.com, mingo@...hat.com, tglx@...utronix.de, mingo@...e.hu
Subject: Re: [tip:sched/core] cpu: Remove incorrect BUG_ON

On Tue, 2010-11-23 at 15:39 +0100, Oleg Nesterov wrote:
> On 11/23, tip-bot for Peter Zijlstra wrote:
> >
> > --- a/kernel/cpu.c
> > +++ b/kernel/cpu.c
> > @@ -249,8 +249,11 @@ static int __ref _cpu_down(unsigned int cpu, int tasks_frozen)
> >  	 * The migration_call() CPU_DYING callback will have removed all
> >  	 * runnable tasks from the cpu, there's only the idle task left now
> >  	 * that the migration thread is done doing the stop_machine thing.
> > +	 *
> > +	 * Wait for the stop thread to go away.
> >  	 */
> > -	BUG_ON(!idle_cpu(cpu));
> > +	while (!idle_cpu(cpu))
> > +		cpu_relax();
> 
> Yes... but I still can't understand why should we wait at all.
> 
> Peter, I am just curious, help ;)

Ah,. uhm,. you mean, not do anything at all?

Dunno, really, let me try and read the code there.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/