linux-kernel - Re: [PATCH 1/3] mfd: Added new regulator_data pointer to ab8500 board configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101123183037.GA19212@rakim.wolfsonmicro.main>
Date:	Tue, 23 Nov 2010 18:30:38 +0000
From:	Mark Brown <broonie@...nsource.wolfsonmicro.com>
To:	Bengt Jonsson <bengt.g.jonsson@...ricsson.com>
Cc:	Liam Girdwood <lrg@...mlogic.co.uk>, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	Linus Walleij <linus.walleij@...ricsson.com>
Subject: Re: [PATCH 1/3] mfd: Added new regulator_data pointer to ab8500
 board configuration

On Tue, Nov 23, 2010 at 07:25:52PM +0100, Bengt Jonsson wrote:

> The ab8500 regulator board configuration will be better separated
> from the MFD board configuration. This patch adds a void pointer
> for this purpose.

Adding something completely typesafe seems like a real loss - if you
want to point to something else at least point to a particular type -
eg, 

struct foo;

struct pdata {
	int other_stuff;
	struct foo *foo;
};

>  	struct regulator_init_data *regulator[AB8500_NUM_REGULATORS];
> +	void *regulator_data;

It'd also help if you could articulate the problem you see with the
current approach...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/