linux-kernel - Re: How about limiting refresh ioctl to sampling events ?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m21v6bdnxf.fsf@gmail.com>
Date:	Wed, 24 Nov 2010 11:19:08 +0100
From:	Francis Moreau <francis.moro@...il.com>
To:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Cc:	Franck Bui-Huu <vagabon.xyz@...il.com>,
	lkml <linux-kernel@...r.kernel.org>
Subject: Re: How about limiting refresh ioctl to sampling events ?

Peter Zijlstra <a.p.zijlstra@...llo.nl> writes:

[...]

>> I'm also wondering if you would accept a second patch which will
>> introduce:
>> 
>> static inline bool is_sampling_event(struct perf_event *event)
>> {
>>         return event->attr.sample_period != 0;
>> }
>> 
>> That would make the code slighlty easier to read IMHO.
>> 
>
> Sure, Francis might want that too, he found another something like this.

Yes there's another issue when counting events are used: they call
perf_event_output() when 'period_left' gets 0 where as they should not.

-- 
Francis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/