linux-kernel - Re: [PATCH] staging/keucr: fix keucr init coding style

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101124130002.GA12939@bicker>
Date:	Wed, 24 Nov 2010 16:00:03 +0300
From:	Dan Carpenter <error27@...il.com>
To:	Al Cho <acho@...ell.com>
Cc:	gregkh@...e.de, linux-kernel@...r.kernel.org,
	devel@...verdev.osuosl.org, yiyingc@....com.tw, jlee@...ell.com,
	segooon@...il.com
Subject: Re: [PATCH] staging/keucr: fix keucr init coding style

On Wed, Nov 24, 2010 at 08:13:29PM +0800, Al Cho wrote:
> -	{
> -		unsigned int pipe = fDir == FDIR_READ ? us->recv_bulk_pipe : us->send_bulk_pipe;
> -		// Bulk
> +	if (buf) {
> +		unsigned int pipe = fDir == \
> +			FDIR_READ ? us->recv_bulk_pipe : us->send_bulk_pipe;
> +		/* Bulk */

This isn't a macro so the '\' character isn't needed.  Although it still
compiles fine so maybe it isn't a big deal.  I would probably do:

		unsigned int pipe;

		if (fDir == FDIR_READ)
			pipe = us->recv_bulk_pipe;
		else
			pipe = us->send_bulk_pipe;

Otherwise it looks good.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/