linux-kernel - Re: [PATCH] x86, dumpstack: Fix unused variable warning.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 24 Nov 2010 14:01:50 +0100
From:	Frederic Weisbecker <fweisbec@...il.com>
To:	Rakib Mullick <rakib.mullick@...il.com>
Cc:	Jesper Juhl <jj@...osbits.net>, Ingo Molnar <mingo@...e.hu>,
	LKML <linux-kernel@...r.kernel.org>, x86@...nel.org
Subject: Re: [PATCH] x86, dumpstack: Fix unused variable warning.

On Wed, Nov 24, 2010 at 04:26:01PM +0600, Rakib Mullick wrote:
> On Wed, Nov 24, 2010 at 3:57 PM, Jesper Juhl <jj@...osbits.net> wrote:
> > On Wed, 24 Nov 2010, Rakib Mullick wrote:
> >
> >
> > So, now the bp variable does not exist at all if CONFIG_FRAME_POINTER is
> > not defined.
>
> Yes - right. And its not used outside CONFIG_FRAME_POINTER.
>
> > That's going to make this line :
> >
> >          show_trace(NULL, NULL, &stack, bp);
> >
> Not clear what are you trying to say. Would you please, clear it up a bit?


I think Jesper is confused because your patch applies on -tip (tip/master or
tip/perf/core) where we have zapped the bp argument from show_trace() lately.

But in the mainline, show_trace() still has the bp argument.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/