[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AANLkTikiTdw1rTxO-wxmutm=vvcxGdTKKCs_roEA7uE-@mail.gmail.com>
Date: Wed, 24 Nov 2010 09:44:52 -0600
From: Timur Tabi <timur@...escale.com>
To: michael@...erman.id.au
Cc: LKML <linux-kernel@...r.kernel.org>,
linux-mips <linux-mips@...ux-mips.org>,
microblaze-uclinux@...e.uq.edu.au,
devicetree-discuss@...ts.ozlabs.org,
linuxppc-dev list <linuxppc-dev@...abs.org>,
sparclinux@...r.kernel.org
Subject: Re: RFC: Mega rename of device tree routines from of_*() to dt_*()
On Wed, Nov 24, 2010 at 8:03 AM, Michael Ellerman
<michael@...erman.id.au> wrote:
> Personally I'm a bit ambivalent about it, the OF name is a bit wrong so
> it would be nice to get rid of, but it's a lot of churn.
>
> So I'm hoping people with either say "YES this is a great idea", or "NO
> this is stupid".
Well, my vote is "no". I wouldn't call it stupid, but I do think it's
a bad idea.
In general, I don't like renaming functions, because it causes
complications with merges and porting code across kernel versions. It
also forces me to re-remember things.
And especially in this case, the churn is too great. You're affecting
files across multiple subsystems and architectures.
--
Timur Tabi
Linux kernel developer at Freescale
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists