lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Wed, 24 Nov 2010 02:14:07 +0200 (EET)
From:	Mika Laitio <lamikr@...ppa.org>
To:	Randy Dunlap <randy.dunlap@...cle.com>
cc:	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org, linux-fsdevel@...r.kernel.org
Subject: Re: [PATCH -mmotm] w1: fix ds2423 build, needs to select CRC16

Thanks for noticing the missing crc16 module selection, it's indeed 
needed if it's not for some other reason selected in the .config.

Mika

> From: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Fix w1_ds2423 build:  needs to select CRC16.
> 
> w1_ds2423.c:(.text+0x9971d): undefined reference to `crc16'
> w1_ds2423.c:(.text+0x9973a): undefined reference to `crc16'
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> Cc: Mika Laitio <lamikr@...ppa.org>
> ---
>  drivers/w1/slaves/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> --- mmotm-2010-1117-1703.orig/drivers/w1/slaves/Kconfig
> +++ mmotm-2010-1117-1703/drivers/w1/slaves/Kconfig
> @@ -18,6 +18,7 @@ config W1_SLAVE_SMEM
>  
>  config W1_SLAVE_DS2423
>  	tristate "Counter 1-wire device (DS2423)"
> +	select CRC16
>  	help
>  	  If you enable this you can read the counter values available
>  	  in the DS2423 chipset from the w1_slave file under the
> 

-- 
Terveisin Mika
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists