linux-kernel - Re: [PATCH] input: joystick: Adding Austria Microsystem AS5011 joystick driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CEE3B37.6030801@armadeus.com>
Date:	Thu, 25 Nov 2010 11:32:23 +0100
From:	Fabien Marteau <fabien.marteau@...adeus.com>
To:	Anirudh Ghayal <anirudhghayal@...il.com>
CC:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Scott Moreau <oreaus@...il.com>, linux-input@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] input: joystick: Adding Austria Microsystem AS5011 joystick
 driver

Hi Anirudh,

Thanks for your code review.

>> +static void as5011_update_axes(struct work_struct *work)
>> +{
>> +       struct as5011_platform_data *plat_dat =
>> +               container_of(work,
>> +                            struct as5011_platform_data,
>> +                            update_axes_work);
>> +       signed char x, y;
>> +
>> +       x = as5011_i2c_read(plat_dat->i2c_client, AS5011_X_RES_INT);
>> +       y = as5011_i2c_read(plat_dat->i2c_client, AS5011_Y_RES_INT);
> 
> What if the read call returns an error ?
It's a problem yes. But I don't know how to manage this error in this context.

>> +static int as5011_probe(struct i2c_client *client,
>> +                       const struct i2c_device_id *id)
>> +{
> 
> __devinit as5011_probe()

Ok, done.

>> +       if (request_irq(plat_dat->int_irq, as5011_int_interrupt,
>> +                       0, plat_dat->int_irq_name, (void *)plat_dat)) {
> 
> How about using request_any_context_irq() ?

Hmm, in fact my platform use a hard IRQ and I used it without question.
I will see how to improve it.
> 
>> +               dev_err(&client->dev, "as5011: Can't allocate int irq %d\n",
>> +                       plat_dat->int_irq);
>> +               retval = -EBUSY;
>> +               goto request_int_irq_error;
>> +       }
>> +
>> +       retval = input_register_device(plat_dat->input_dev);
> 
> Its better to register your device at the end, after all the initialization.

Yes it was a mistake. Done.
> 
>> +       if (retval) {
>> +               dev_err(&client->dev, "as5011: Failed to register device\n");
>> +               retval = -EINVAL;
>> +               goto input_register_device_error;
>> +       }
>> +
>> +       retval = plat_dat->init_gpio();
> 
> Please check if the function pointer is NULL.

Ok, done.

>> +       plat_dat->exit_gpio();
> 
> Please check if the function pointer is NULL.
done.

>> +       plat_dat->exit_gpio();
> 
> Same here.
done.


>> +       .remove         = as5011_remove,
> 
> __devexit_p (as5011_remove)
done.

Thanks.
Fabien

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/