linux-kernel - Re: [PATCH 1/2] perf_events: add support for per-cpu per-cgroup monitoring (v5)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTim23nB7gL_wfanxGjJBHvE-7VpSjQ4wU4cQ_fG3@mail.gmail.com>
Date:	Thu, 25 Nov 2010 15:53:00 +0100
From:	Stephane Eranian <eranian@...gle.com>
To:	Peter Zijlstra <peterz@...radead.org>
Cc:	linux-kernel@...r.kernel.org, mingo@...e.hu, paulus@...ba.org,
	davem@...emloft.net, fweisbec@...il.com,
	perfmon2-devel@...ts.sf.net, eranian@...il.com,
	robert.richter@....com, acme@...hat.com, lizf@...fujitsu.com
Subject: Re: [PATCH 1/2] perf_events: add support for per-cpu per-cgroup
 monitoring (v5)

On Thu, Nov 25, 2010 at 12:20 PM, Peter Zijlstra <peterz@...radead.org> wrote:
>
> On Thu, 2010-11-18 at 12:40 +0200, Stephane Eranian wrote:
> > @@ -919,6 +945,10 @@ static inline void perf_event_task_sched_in(struct task_struct *task)
> >  static inline
> >  void perf_event_task_sched_out(struct task_struct *task, struct task_struct *next)
> >  {
> > +#ifdef CONFIG_CGROUPS
> > +       atomic_t *cgroup_events = &__get_cpu_var(perf_cgroup_events);
> > +       COND_STMT(cgroup_events, perf_cgroup_switch(task, next));
> > +#endif
> >         COND_STMT(&perf_task_events, __perf_event_task_sched_out(task, next));
> >  }
>
> I don't think that'll actually work, the jump label stuff needs a static
> address.
>

I did not know that.

> Why not simply: s/perf_task_events/perf_sched_events/ and increment it
> for cgroup events as well?
>

But you would need to demultiplex. that's not because perf_sched_events is
set that you want BOTH perf_cgroup_switch() AND perf_event_task_sched_out().
Cgroup mode is per-cpu only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/