| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Nov 2010 19:15:50 +0300 From: Anton Vorontsov <cbouatmailru@...il.com> To: Alan Stern <stern@...land.harvard.edu> Cc: Lin Mac <mkl0301@...il.com>, linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, dbrownell@...rs.sourceforge.net, linux-usb@...r.kernel.org Subject: Re: [PATCH v2 2/3] ARM: cns3xxx: Add architecture definition for EHCI/OHCI controller On Thu, Nov 25, 2010 at 10:37:16AM -0500, Alan Stern wrote: > > > 2010/11/25 Anton Vorontsov <cbouatmailru@...il.com>: > > > > On Thu, Nov 25, 2010 at 03:25:38PM +0800, Lin Mac wrote: > > > > [...] > > > >> > Â #include <linux/module.h> > > > >> > Â #include <linux/io.h> > > > >> > Â #include <linux/delay.h> > > > >> > +#include <asm/atomic.h> > > > >> It's not necessary for mach/pm.h already included it, right? > > > > > > > > Technically, it's not necessary. But in Linux we don't rely on > > > > headers including other headers. > > Just saw this. Don't be ridiculous -- this happens all over the place. > People generally aren't aware of it, because it's next to impossible to > verify that all the headers needed by a source file are included > directly. Sure. But that doesn't mean we shouldn't try to keep these things sane enough. I just noticed that the patch introduced atomic_t usage, but didn't include asm/atomic.h, so I corrected this before applying that patch. So I don't see what's the fuss is about. :-) Thanks, -- Anton Vorontsov Email: cbouatmailru@...il.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists