lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 25 Nov 2010 18:35:18 +0100 From: Andrea Arcangeli <aarcange@...hat.com> To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Mel Gorman <mel@....ul.ie>, linux-mm@...ck.org, Andrew Morton <akpm@...ux-foundation.org>, linux-kernel@...r.kernel.org, Marcelo Tosatti <mtosatti@...hat.com>, Adam Litke <agl@...ibm.com>, Avi Kivity <avi@...hat.com>, Hugh Dickins <hugh.dickins@...cali.co.uk>, Rik van Riel <riel@...hat.com>, Dave Hansen <dave@...ux.vnet.ibm.com>, Benjamin Herrenschmidt <benh@...nel.crashing.org>, Ingo Molnar <mingo@...e.hu>, Mike Travis <travis@....com>, KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>, Christoph Lameter <cl@...ux-foundation.org>, Chris Wright <chrisw@...s-sol.org>, bpicco@...hat.com, KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>, Balbir Singh <balbir@...ux.vnet.ibm.com>, "Michael S. Tsirkin" <mst@...hat.com>, Peter Zijlstra <peterz@...radead.org>, Johannes Weiner <hannes@...xchg.org>, Daisuke Nishimura <nishimura@....nes.nec.co.jp>, Chris Mason <chris.mason@...cle.com>, Borislav Petkov <bp@...en8.de> Subject: Re: [PATCH 17 of 66] add pmd mangling generic functions On Thu, Nov 18, 2010 at 09:32:36AM -0800, Linus Torvalds wrote: > I dunno. Those macros are _way_ too big and heavy to be macros or > inline functions. Why aren't pmdp_splitting_flush() etc just > functions? That's because ptep_clear_flush and everything else in that file named with ptep_* and doing expensive tlb flushes was a macro. > > There is no performance advantage to inlining them - the TLB flush is > going to be expensive enough that there's no point in avoiding a > function call. And that header file really does end up being _really_ > ugly. I agree but to me it looks like your compliant applies to the current include/asm-generic/pgtable.h. My changes that simply mirrors closely the style of that file to avoid altering coding style just for the new stuff. That is compact code that I'm not even sure if anybody is using, most certainly x86 isn't using that code so the .text bloat isn't a practical concern. Do you like me to do a cleanup of the asm-generic/pgtable.h and move the tlb flushes to lib/pgtable.c? (ideally the pgtable.o file should be empty after the preprocessor runs on x86*) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists