linux-kernel - Re: How do I choose an arbitrary minor number for my tty device?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTikG3EfWRpY5DNGyjYgxJt9O+qkPr7onS60rRzw_@mail.gmail.com>
Date:	Wed, 24 Nov 2010 21:10:36 -0700
From:	Grant Likely <grant.likely@...retlab.ca>
To:	michael@...erman.id.au
Cc:	Scott Wood <scottwood@...escale.com>,
	Timur Tabi <timur@...escale.com>, Greg KH <gregkh@...e.de>,
	Arnd Bergmann <arnd@...db.de>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Stuart Yoder <stuart.yoder@...escale.com>,
	devicetree-discuss@...r.kernel.org
Subject: Re: How do I choose an arbitrary minor number for my tty device?

On Wed, Nov 24, 2010 at 3:46 PM, Michael Ellerman
<michael@...erman.id.au> wrote:
> On Wed, 2010-11-24 at 12:08 -0600, Scott Wood wrote:
>> On Wed, 24 Nov 2010 21:23:47 +1100
>> Michael Ellerman <michael@...erman.id.au> wrote:
>
>> > > It would be nice if platform devices that are created from device tree
>> > > nodes included a link to the corresponding /proc/device-tree node in
>> > > their sysfs node.
>> >
>> > It's not a link, but the OF path is in devspec, so you can work it out
>> > fairly easily.
>>
>> Hmm, I see a "devspec" in PCI devices, but not in devtree-probed
>> platform devices.  of_bus_type_init isn't being called from anywhere
>> but the ibmebus code.  It looks like this was a casualty of merging
>> of_platform with platform (commit eca3930163ba8884060ce9d9ff5ef0d9b7c7b00f).
>
> Ah crud, yeah I was looking at an old kernel.
>
> That seems like a regression, but seemingly no one has complained so
> perhaps it doesn't matter in practice. It was certainly a nice feature
> though.

Hmmm, I missed that when merging.  Oops.

devspec is easy enough to add back since there isn't a conflict.  It
can even be made system-wide (not just platform bus) since any device
can have an of_node now.  However, the modalias and name attributes
are a lot harder since there are name conflicts.

g.

-- 
Grant Likely, B.Sc., P.Eng.
Secret Lab Technologies Ltd.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/