lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Date:	Fri, 26 Nov 2010 11:57:18 +0100
From:	Samuel Ortiz <sameo@...ux.intel.com>
To:	Andres Salomon <dilinger@...ued.net>
Cc:	linux-geode@...ts.infradead.org, linux-kernel@...r.kernel.org,
	akpm@...ux-foundation.org, cjb@...top.org, dsd@...top.org
Subject: Re: [PATCH 1/4] MFD: add cs5535-mfd driver for CS5535/CS5536
 support

Hi Andres,

On Sat, Oct 23, 2010 at 12:41:02AM -0700, Andres Salomon wrote:
> 
> Add an MFD driver to handle the ISA device on CS5535 and CS5536 southbridges.
> This ISA bridge is actually multiple devices; GPIOs, MFGPTs, etc.
The patch looks good, and I applied it.
I just have one minor nitpick though, that you may want to address with a
further patch:

> +config MFD_CS5535
> +	tristate "Support for CS5535 and CS5536 southbridge core functions"
An AMD Geode mention should appear here. It might not be obvious to everyone
where those devices can be found.

Cheers,
Samuel.

-- 
Intel Open Source Technology Centre
http://oss.intel.com/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ