linux-kernel - Re: [PATCH 1/1] TTY: don't allow reopen when ldisc is changing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 25 Nov 2010 19:28:40 -0500
From:	Kyle McMartin <kyle@...artin.ca>
To:	Jiri Slaby <jslaby@...e.cz>
Cc:	gregkh@...e.de, akpm@...ux-foundation.org,
	linux-kernel@...r.kernel.org, jirislaby@...il.com,
	Kyle McMartin <kyle@...artin.ca>,
	Alan Cox <alan@...rguk.ukuu.org.uk>
Subject: Re: [PATCH 1/1] TTY: don't allow reopen when ldisc is changing

On Thu, Nov 25, 2010 at 06:16:23PM +0100, Jiri Slaby wrote:
> -	if (test_bit(TTY_CLOSING, &tty->flags))
> +	if (test_bit(TTY_CLOSING, &tty->flags) ||
> +			test_bit(TTY_LDISC_CHANGING, &tty->flags))
>  		return -EIO;
>  
>  	if (driver->type == TTY_DRIVER_TYPE_PTY &&

Unfortunately, users report this doesn't seem to fix things for them
(built against 2.6.36 (plus another patch you wrote iirc.))

https://bugzilla.redhat.com/show_bug.cgi?id=630464#c27

I tried reverting the TTY patches between 2.6.36 and 2.6.35 and getting
them to test that, and it seems ok:

https://bugzilla.redhat.com/show_bug.cgi?id=630464#c30

So I guess there must be a race here somewhere... I'll keep looking. :/

I would imagine it's something that's probably existed since the dawn of
time but the BKL has just papered over entirely.

Thanks for trying!
  --Kyle
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/