linux-kernel - Re: [PATCH] printk: use this_cpu_{read|write} api on printk

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1290788988.2145.152.camel@laptop>
Date:	Fri, 26 Nov 2010 17:29:48 +0100
From:	Peter Zijlstra <a.p.zijlstra@...llo.nl>
To:	Eric Dumazet <eric.dumazet@...il.com>
Cc:	mingo@...hat.com, hpa@...or.com, linux-kernel@...r.kernel.org,
	heiko.carstens@...ibm.com, tglx@...utronix.de, mingo@...e.hu,
	Christoph Lameter <cl@...ux.com>
Subject: Re: [PATCH] printk: use this_cpu_{read|write} api on printk_pending

On Fri, 2010-11-26 at 17:22 +0100, Eric Dumazet wrote:
> [PATCH] printk: use this_cpu_{read|write} api on printk_pending
> 
> __get_cpu_var() is a bit inefficient, lets use __this_cpu_read() and
> __this_cpu_write() to manipulate printk_pending.
> 
> printk_needs_cpu(cpu) is called only for the current cpu :
> Use faster __this_cpu_read().
> 
> remove the redondant unlikely on (cpu_is_offline(cpu)) test
> 
> # size kernel/printk.o*
>    text    data     bss     dec     hex filename
>    9942     756  263488  274186   42f0a kernel/printk.o.new
>    9990     756  263488  274234   42f3a kernel/printk.o.old


Thanks, queued!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/