linux-kernel - Re: [PATCH] sh: boards: mach-se: use IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Pine.LNX.4.64.1011261835500.16655@axis700.grange>
Date:	Fri, 26 Nov 2010 18:38:23 +0100 (CET)
From:	Guennadi Liakhovetski <g.liakhovetski@....de>
To:	Vasiliy Kulikov <segoon@...nwall.com>
cc:	kernel-janitors@...r.kernel.org, Paul Mundt <lethal@...ux-sh.org>,
	Kuninori Morimoto <kuninori.morimoto.gx@...esas.com>,
	Magnus Damm <damm@...nsource.se>, linux-sh@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] sh: boards: mach-se: use IS_ERR() instead of NULL check

On Fri, 26 Nov 2010, Vasiliy Kulikov wrote:

> clk_get() returns ERR_PTR() on error, not NULL.
> 
> Signed-off-by: Vasiliy Kulikov <segoon@...nwall.com>

Yep, there are, probably, a couple more of these, similar to

http://marc.info/?t=128715350900002&r=1&w=2

Hardly required, but if you like:

Reviewed-by: Guennadi Liakhovetski <g.liakhovetski@....de>

Thanks
Guennadi

> ---
>  Cannot compile this driver, so it is not tested at all.
> 
>  arch/sh/boards/mach-se/7724/setup.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/sh/boards/mach-se/7724/setup.c b/arch/sh/boards/mach-se/7724/setup.c
> index c31d228..6735305 100644
> --- a/arch/sh/boards/mach-se/7724/setup.c
> +++ b/arch/sh/boards/mach-se/7724/setup.c
> @@ -871,14 +871,14 @@ static int __init devices_setup(void)
>  
>  	/* set SPU2 clock to 83.4 MHz */
>  	clk = clk_get(NULL, "spu_clk");
> -	if (clk) {
> +	if (!IS_ERR(clk)) {
>  		clk_set_rate(clk, clk_round_rate(clk, 83333333));
>  		clk_put(clk);
>  	}
>  
>  	/* change parent of FSI A */
>  	clk = clk_get(NULL, "fsia_clk");
> -	if (clk) {
> +	if (!IS_ERR(clk)) {
>  		clk_register(&fsimcka_clk);
>  		clk_set_parent(clk, &fsimcka_clk);
>  		clk_set_rate(clk, 11000);
> -- 
> 1.7.0.4
> 
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/