linux-kernel - Re: [PATCH][trivial] Kill off a bunch of annoying warning: ‘inline’ is not at beginning of declaration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <alpine.LNX.2.00.1011282310160.29621@swampdragon.chaosbits.net>
Date:	Sun, 28 Nov 2010 23:12:02 +0100 (CET)
From:	Jesper Juhl <jj@...osbits.net>
To:	Jiri Kosina <jkosina@...e.cz>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Andrew Morton <akpm@...ux-foundation.org>
Subject: Re: [PATCH][trivial] Kill off a bunch of annoying  warning: ‘inline’ is not at beginning of declaration

On Sun, 28 Nov 2010, Jiri Kosina wrote:

> On Sun, 28 Nov 2010, Jesper Juhl wrote:
> 
> > Hi,
> > 
> > These warnings are spewed during a build of a 'allnoconfig' kernel 
> > (especially the ones from u64_stats_sync.h show up a lot) when building 
> > with -Wextra (which I often do)..
> > They are
> >   a) annoying
> >   b) easy to get rid of.
> > This patch kills them off.
> 
> Hmm, this made me look into what -Wextra actually does ... and it seems 
> quite fishy for kernel. For example my gcc manpage tells me
> 
>        -Wempty-body
>            Warn if an empty body occurs in an if, else or do while statement.
> 	   This warning is also enabled by -Wextra.
> 
> And we do have quite a bunch of 'do { } while (0);' in kernel. So it seems 
> to me like you'll be getting much more noise with -Wextra than the lines 
> below, won't you?
> 

Yes, I'm getting a lot of noise, and most of it I'll just live with since 
it's not relevant.
But, some of it - like what this patch addresses - is noise that can 
easily just go away and I think it should.

-- 
Jesper Juhl <jj@...osbits.net>            http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/