| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <1290936047.16349.13.camel@Joe-Laptop> Date: Sun, 28 Nov 2010 01:20:47 -0800 From: Joe Perches <joe@...ches.com> To: Johannes Berg <johannes@...solutions.net> Cc: Daniel Drake <dsd@...too.org>, Ulrich Kunitz <kune@...ne-taler.de>, linux-wireless@...r.kernel.org, "John W. Linville" <linville@...driver.com>, linux-kernel@...r.kernel.org, netdev <netdev@...r.kernel.org> Subject: Re: [PATCH 4/4] zd1211rw: remove unnecessary [kv][mcz]alloc casts On Sun, 2010-11-28 at 10:12 +0100, Johannes Berg wrote: > On Sun, 2010-11-28 at 01:05 -0800, Joe Perches wrote: > > diff --git a/drivers/net/wireless/zd1211rw/zd_chip.c b/drivers/net/wireless/zd1211rw/zd_chip.c > > @@ -117,8 +117,7 @@ int zd_ioread32v_locked(struct zd_chip *chip, u32 *values, const zd_addr_t *addr > > > > /* Allocate a single memory block for values and addresses. */ > > count16 = 2*count; > > - a16 = (zd_addr_t *) kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)), > > - GFP_KERNEL); > > + a16 = kmalloc(count16 * (sizeof(zd_addr_t) + sizeof(u16)), GFP_KERNEL); > I believe this is on purpose for sparse. Perhaps in a previous version, but not now. $ make C=1 drivers/net/wireless/zd1211rw/zd_chip.o CHK include/linux/version.h CHK include/generated/utsrelease.h CALL scripts/checksyscalls.sh CHECK drivers/net/wireless/zd1211rw/zd_chip.c include/trace/events/kmem.h:45:1: error: Expected ( after asm include/trace/events/kmem.h:45:1: error: got goto include/trace/events/kmem.h:53:1: error: Expected ( after asm include/trace/events/kmem.h:53:1: error: got goto include/trace/events/kmem.h:99:1: error: Expected ( after asm include/trace/events/kmem.h:99:1: error: got goto include/trace/events/kmem.h:108:1: error: Expected ( after asm include/trace/events/kmem.h:108:1: error: got goto include/trace/events/kmem.h:136:1: error: Expected ( after asm include/trace/events/kmem.h:136:1: error: got goto include/trace/events/kmem.h:143:1: error: Expected ( after asm include/trace/events/kmem.h:143:1: error: got goto include/trace/events/kmem.h:150:1: error: Expected ( after asm include/trace/events/kmem.h:150:1: error: got goto include/trace/events/kmem.h:172:1: error: Expected ( after asm include/trace/events/kmem.h:172:1: error: got goto include/trace/events/kmem.h:194:1: error: Expected ( after asm include/trace/events/kmem.h:194:1: error: got goto include/trace/events/kmem.h:249:1: error: Expected ( after asm include/trace/events/kmem.h:249:1: error: got goto include/trace/events/kmem.h:256:1: error: Expected ( after asm include/trace/events/kmem.h:256:1: error: got goto include/trace/events/kmem.h:267:1: error: Expected ( after asm include/trace/events/kmem.h:267:1: error: got goto include/trace/events/module.h:18:1: error: Expected ( after asm include/trace/events/module.h:18:1: error: got goto include/trace/events/module.h:37:1: error: Expected ( after asm include/trace/events/module.h:37:1: error: got goto include/trace/events/module.h:79:1: error: Expected ( after asm include/trace/events/module.h:79:1: error: got goto include/trace/events/module.h:86:1: error: Expected ( after asm include/trace/events/module.h:86:1: error: got goto include/trace/events/module.h:94:1: error: Expected ( after asm include/trace/events/module.h:94:1: error: got goto /home/joe/linux/net-next-2.6-2/arch/x86/include/asm/uaccess_32.h:197:9: error: attribute 'error': unknown attribute include/trace/events/irq.h:37:1: error: Expected ( after asm include/trace/events/irq.h:37:1: error: got goto include/trace/events/irq.h:67:1: error: Expected ( after asm include/trace/events/irq.h:67:1: error: got goto include/trace/events/irq.h:112:1: error: Expected ( after asm include/trace/events/irq.h:112:1: error: got goto include/trace/events/irq.h:126:1: error: Expected ( after asm include/trace/events/irq.h:126:1: error: got goto include/trace/events/irq.h:140:1: error: Expected ( after asm include/trace/events/irq.h:140:1: error: got goto include/trace/events/kmem.h:45:1: error: need constant string for inline asm include/trace/events/kmem.h:45:1: error: incompatible types in comparison expression (different address spaces) include/trace/events/kmem.h:45:1: error: need constant string for inline asm include/trace/events/kmem.h:45:1: error: incompatible types in comparison expression (different address spaces) include/trace/events/kmem.h:45:1: error: need constant string for inline asm include/trace/events/kmem.h:45:1: error: incompatible types in comparison expression (different address spaces) include/trace/events/kmem.h:45:1: error: need constant string for inline asm include/trace/events/kmem.h:45:1: error: incompatible types in comparison expression (different address spaces) CC drivers/net/wireless/zd1211rw/zd_chip.o $ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists