linux-kernel - Re: [PATCH 0/2] overlayfs fixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101128191813.GC11339@shadowen.org>
Date:	Sun, 28 Nov 2010 19:18:14 +0000
From:	Andy Whitcroft <apw@...onical.com>
To:	Miklos Szeredi <miklos@...redi.hu>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	vaurora@...hat.com, neilb@...e.de, viro@...iv.linux.org.uk
Subject: Re: [PATCH 0/2] overlayfs fixes

On Thu, Nov 25, 2010 at 04:06:55PM +0100, Miklos Szeredi wrote:
> On Wed, 17 Nov 2010, Andy Whitcroft wrote:
> >   overlayfs: handle missing lower inodes in ovl_is_same_inode
> 
> I don't see how this could be needed.  vfs_is_same_inode() checks if
> the dentries are positive.  In that case either the upper dentry or
> the lower dentry or both must exist.

It was cirtinaly exploding in my tests without that change.  The test
case was overlaying a tmpfs over a squashfs.

> >   overlayfs: ovl_copy_up_xattr -- handle EOPNOTSUPP from vfs_listxattr
> 
> Applied.  Thanks, Andy.
> 
> I pushed an updated version based on v2.6.37-rc3 to the overlayfs.v5
> branch:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/mszeredi/vfs.git overlayfs.v5
> 
> Thanks,
> Miklos

I'll retest with that version and see if the first patch is still
required.

Thanks for the updated version.

-apw
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/