linux-kernel - Re: [PATCH] Repalce strncmp by memcmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87eia4l9gn.fsf@basil.nowhere.org>
Date:	Mon, 29 Nov 2010 11:18:00 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	pavel@...linux.ru
Cc:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Repalce strncmp by memcmp

Pavel Vasilyev <pavel@...linux.ru> writes:

>     This patch replace all strncmp(a, b, c) by  memcmp(a, b, c).

Those two calls are not equivalent. Think what happens when a or b
are shorter than n and one of them is at the end of a page 
before a memory hole.

-Andi

-- 
ak@...ux.intel.com -- Speaking for myself only.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/