lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1291028919.3299.137.camel@odin>
Date:	Mon, 29 Nov 2010 11:08:39 +0000
From:	Liam Girdwood <lrg@...mlogic.co.uk>
To:	Axel Lin <axel.lin@...il.com>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>,
	Timur Tabi <timur@...escale.com>,
	Mark Brown <broonie@...nsource.wolfsonmicro.com>,
	alsa-devel@...a-project.org
Subject: Re: [PATCH 1/2] ASoC: Add missing dev_set_drvdata in
 mpc8610_hpcd_probe

On Mon, 2010-11-29 at 14:54 +0800, Axel Lin wrote:
> Otherwise, calling dev_get_drvdata in mpc8610_hpcd_remove returns NULL.
> 
> Signed-off-by: Axel Lin <axel.lin@...il.com>
> ---
>  sound/soc/fsl/mpc8610_hpcd.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/soc/fsl/mpc8610_hpcd.c b/sound/soc/fsl/mpc8610_hpcd.c
> index 0d7dcf1..7d7847a 100644
> --- a/sound/soc/fsl/mpc8610_hpcd.c
> +++ b/sound/soc/fsl/mpc8610_hpcd.c
> @@ -498,6 +498,7 @@ static int mpc8610_hpcd_probe(struct platform_device *pdev)
>  		dev_err(&pdev->dev, "platform device add failed\n");
>  		goto error;
>  	}
> +	dev_set_drvdata(&pdev->dev, sound_device);
>  
>  	of_node_put(codec_np);
>  

All

Acked-by: Liam Girdwood <lrg@...mlogic.co.uk>
-- 
Freelance Developer, SlimLogic Ltd
ASoC and Voltage Regulator Maintainer.
http://www.slimlogic.co.uk

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ