linux-kernel - Re: [BUGFIX] vmstat: fix dirty threshold ordering

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20101129202124.82CC.A69D9226@jp.fujitsu.com>
Date:	Mon, 29 Nov 2010 20:21:36 +0900 (JST)
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Wu Fengguang <fengguang.wu@...el.com>
Cc:	kosaki.motohiro@...fujitsu.com,
	Andrew Morton <akpm@...ux-foundation.org>,
	Michael Rubin <mrubin@...gle.com>,
	Linux Memory Management List <linux-mm@...ck.org>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [BUGFIX] vmstat: fix dirty threshold ordering

> The nr_dirty_[background_]threshold fields are misplaced before the
> numa_* fields, and users will read strange values.
> 
> This is the right order. Before patch, nr_dirty_background_threshold
> will read as 0 (the value from numa_miss).
> 
> 	numa_hit 128501
> 	numa_miss 0
> 	numa_foreign 0
> 	numa_interleave 7388
> 	numa_local 128501
> 	numa_other 0
> 	nr_dirty_threshold 144291
> 	nr_dirty_background_threshold 72145
> 
> Cc: Michael Rubin <mrubin@...gle.com>
> Signed-off-by: Wu Fengguang <fengguang.wu@...el.com>

Obviously. :-/

Thanks, Wu.

	Reviewed-by: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>


> ---
>  mm/vmstat.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --- linux-next.orig/mm/vmstat.c	2010-11-28 16:02:12.000000000 +0800
> +++ linux-next/mm/vmstat.c	2010-11-28 16:02:24.000000000 +0800
> @@ -750,8 +750,6 @@ static const char * const vmstat_text[] 
>  	"nr_shmem",
>  	"nr_dirtied",
>  	"nr_written",
> -	"nr_dirty_threshold",
> -	"nr_dirty_background_threshold",
>  
>  #ifdef CONFIG_NUMA
>  	"numa_hit",
> @@ -761,6 +759,8 @@ static const char * const vmstat_text[] 
>  	"numa_local",
>  	"numa_other",
>  #endif
> +	"nr_dirty_threshold",
> +	"nr_dirty_background_threshold",
>  
>  #ifdef CONFIG_VM_EVENT_COUNTERS
>  	"pgpgin",
> 
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@...ck.org.  For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Fight unfair telecom policy in Canada: sign http://dissolvethecrtc.ca/
> Don't email: <a href=mailto:"dont@...ck.org"> email@...ck.org </a>



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/