linux-kernel - Re: ath9k_htc vs. powerpc (was Re: working usb wifi card, that is still possible to buy)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20101129125705.GB31518@pma.sysgo.com>
Date:	Mon, 29 Nov 2010 13:57:05 +0100
From:	Pavel Machek <pma@...go.com>
To:	Sujith <m.sujith@...il.com>
Cc:	Larry Finger <Larry.Finger@...inger.net>,
	"ath9k-devel@...ema.h4ckr.net" <ath9k-devel@...ema.h4ckr.net>,
	kernel list <linux-kernel@...r.kernel.org>,
	"chunkeey@...glemail.com" <chunkeey@...glemail.com>,
	"linux-wireless@...r.kernel.org" <linux-wireless@...r.kernel.org>,
	"rudolf.marek@...go.com" <rudolf.marek@...go.com>,
	"cko@...go.com" <cko@...go.com>, "mfa@...go.com" <mfa@...go.com>,
	"anl@...go.com" <anl@...go.com>
Subject: Re: ath9k_htc vs. powerpc (was Re: working usb wifi card, that is
 still possible to buy)

Hi!

> > ...so I indentified two endianness problems in eeprom, but even with
> > both fixed, it still will not associate. Is there some way to dump USB
> > packets, then compare them between PC and PowerPC versions? Should I
> > expect them to match?
> 
> Does this patch help ?

Actually I wonder...

> diff --git a/drivers/net/wireless/ath/ath9k/htc_drv_main.c b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> index e9761c2..1b435d4 100644
> --- a/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> +++ b/drivers/net/wireless/ath/ath9k/htc_drv_main.c
> @@ -204,7 +204,7 @@ static int ath9k_htc_add_station(struct ath9k_htc_priv *priv,
>  		ista = (struct ath9k_htc_sta *) sta->drv_priv;
>  		memcpy(&tsta.macaddr, sta->addr, ETH_ALEN);
>  		memcpy(&tsta.bssid, common->curbssid, ETH_ALEN);
> -		tsta.associd = common->curaid;
> +		tsta.associd = cpu_to_be16(common->curaid);
>  		tsta.is_vif_sta = 0;
>  		tsta.valid = true;
>  		ista->index = priv->nstations;

We know the code currently works on PC; but this adds conversions that
are nop on PowerPC and do something on PC... so they should have no
effect on PowerPC and could break PC...?
									Pavel
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/