linux-kernel - Re: [PATCH] ARM: Gemini: Add support for PCI BUS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201011291602.54932.arnd@arndb.de>
Date:	Mon, 29 Nov 2010 16:02:54 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Hans Ulli Kroll <ulli.kroll@...glemail.com>
Cc:	linux-arm-kernel@...ts.infradead.org,
	Russell King <linux@....linux.org.uk>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: Gemini: Add support for PCI BUS

On Monday 29 November 2010, Hans Ulli Kroll wrote:
> > 
> > This looks wrong in multiple ways:
> > 
> > * resources are physical addresses, not virtual addresses
> > * GEMINI_PCI_IO_BASE is an address in memory space, so it
> >   needs to be IORESOURCE_MEM, not IORESOURCE_IO. You can
> >   also register the IORESOURCE_IO resource, but that would
> >   be .start=PCIBIOS_MIN_IO, .end=IO_SPACE_LIMIT.
> > * IO_SPACE_LIMIT is larger than the I/O window, which can
> >   cause overflows. Setting it to 0xffff is generally enough.
> > 
> 
> So I must remove these lines ??
>         }, {
>                 .virtual        = IO_ADDRESS(GEMINI_PCI_IO_BASE),
>                 .pfn            = __phys_to_pfn(GEMINI_PCI_IO_BASE),
>                 .length         = SZ_512K,
>                 .type           = MT_DEVICE,
>         },
> These are from arch/arm/mach-gemini/mm.c

No, these look right, just fix the issues I mentioned, i.e.
the definition of IO_SPACE_LIMIT and the resource registration.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/