linux-kernel - Re: [PATCH] ARM: Gemini: Add support for PCI Bus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <201011291657.53316.arnd@arndb.de>
Date:	Mon, 29 Nov 2010 16:57:53 +0100
From:	Arnd Bergmann <arnd@...db.de>
To:	Hans Ulli Kroll <ulli.kroll@...glemail.com>
Cc:	"Russell King - ARM Linux" <linux@....linux.org.uk>,
	linux-arm-kernel@...ts.infradead.org,
	Michał Mirosław <mirqus@...il.com>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: Gemini: Add support for PCI Bus

On Monday 29 November 2010, Hans Ulli Kroll wrote:
> @@ -1164,7 +1169,7 @@ config ISA_DMA_API
>         bool
>  
>  config PCI
> -       bool "PCI support" if ARCH_INTEGRATOR_AP || ARCH_VERSATILE_PB || 
> ARCH_IXP4XX || ARCH_KS8695 || MACH_ARMCORE || ARCH_CNS3XXX
> +       bool "PCI support" if MIGHT_HAVE_PCI
>         help
>           Find out whether you have a PCI motherboard. PCI is the name of 
> a
>           bus system, i.e. the way the CPU talks to the other stuff inside

This does not solve the problem that Russell mentioned: existing platforms
select PCI unconditionally, e.g. Iop13XX, some IXP, Orion, Shark
and more. At the very least, these would need to also select MIGHT_HAVE_PCI
to avoid the warning.

> index fe0c82e..f5c39a8 100644
> --- a/arch/arm/mach-ks8695/Kconfig
> +++ b/arch/arm/mach-ks8695/Kconfig
> @@ -4,6 +4,7 @@ menu "Kendin/Micrel KS8695 Implementations"
>  
>  config MACH_KS8695
>         +++ b/arch/arm/mach-versatile/Kconfig
> @@ -4,6 +4,7 @@ menu "Versatile platform type"
>  config ARCH_VERSATILE_PB
>         bool "Support Versatile/PB platform"
>         select CPU_ARM926T
> +       select HAVE_PCI
>         default y
>         help
>           Include support for the ARM(R) Versatile/PB platform.bool 

Typo: you certainly meant MIGHT_HAVE_PCI here.

We still need to agree on what it should be doing, but otherwise this
is what I had in mind.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/