linux-kernel - Re: [thisops uV2 06/10] vmstat: Use this_cpu_inc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Nov 2010 10:04:40 -0600 (CST)
From:	Christoph Lameter <cl@...ux.com>
To:	Pekka Enberg <penberg@...nel.org>
cc:	akpm@...ux-foundation.org, Pekka Enberg <penberg@...helsinki.fi>,
	linux-kernel@...r.kernel.org,
	Eric Dumazet <eric.dumazet@...il.com>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Tejun Heo <tj@...nel.org>
Subject: Re: [thisops uV2 06/10] vmstat: Use this_cpu_inc_return for vm
 statistics

On Sat, 27 Nov 2010, Pekka Enberg wrote:

> > @@ -167,8 +167,8 @@ static void refresh_zone_stat_thresholds
> >  void __mod_zone_page_state(struct zone *zone, enum zone_stat_item item,
> >                                int delta)
> >  {
> > -       struct per_cpu_pageset * __percpu pcp = zone->pageset;
> > -       s8 * __percpu p = pcp->vm_stat_diff + item;
> > +       struct per_cpu_pageset __percpu *pcp = zone->pageset;
> > +       s8 __percpu *p = pcp->vm_stat_diff + item;
> >        long x;
> >        long t;
> >
>
> Shouldn't this hunk be in the other vmstat patch?

Right. I did not run sparse with the first patch alone.