| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-Id: <20101129134943.4ef92448.randy.dunlap@oracle.com> Date: Mon, 29 Nov 2010 13:49:43 -0800 From: Randy Dunlap <randy.dunlap@...cle.com> To: Peter Huewe <peterhuewe@....de> Cc: Greg Kroah-Hartman <gregkh@...e.de>, devel@...verdev.osuosl.org, linux-kernel@...r.kernel.org, Mark Allyn <mark.a.allyn@...el.com>, Joe Perches <joe@...ches.com>, Ben Hutchings <ben@...adent.org.uk>, Alan Cox <alan@...ux.intel.com> Subject: Re: [PATCH 3/3] staging/sep: Fix sparse printk format warning On Mon, 29 Nov 2010 22:31:20 +0100 Peter Huewe wrote: > This patch fixes sparse's complaints about the wrong format string. Are you sure? I'm used to these being gcc warnings, not sparse. Also, this fixes the warnings on x86_64 but not on x86_32/i386: linux-next-20101126/drivers/staging/sep/sep_driver.c: In function 'sep_ioctl': linux-next-20101126/drivers/staging/sep/sep_driver.c:3397: warning: format '%lx' expects type 'long unsigned int', but argument 4 has type 'unsigned int' linux-next-20101126/drivers/staging/sep/sep_driver.c:3399: warning: format '%lx' expects type 'long unsigned int', but argument 4 has type 'unsigned int' linux-next-20101126/drivers/staging/sep/sep_driver.c:3405: warning: format '%lx' expects type 'long unsigned int', but argument 4 has type 'unsigned int' linux-next-20101126/drivers/staging/sep/sep_driver.c:3407: warning: format '%lx' expects type 'long unsigned int', but argument 4 has type 'unsigned int' linux-next-20101126/drivers/staging/sep/sep_driver.c:3411: warning: format '%lx' expects type 'long unsigned int', but argument 4 has type 'unsigned int' linux-next-20101126/drivers/staging/sep/sep_driver.c:3413: warning: format '%lx' expects type 'long unsigned int', but argument 4 has type 'unsigned int' linux-next-20101126/drivers/staging/sep/sep_driver.c:3415: warning: format '%lx' expects type 'long unsigned int', but argument 4 has type 'unsigned int' > Signed-off-by: Peter Huewe <peterhuewe@....de> > --- > LinuxVersion: linux-next-20101129 > > drivers/staging/sep/sep_driver.c | 26 +++++++++++++------------- > 1 files changed, 13 insertions(+), 13 deletions(-) > > diff --git a/drivers/staging/sep/sep_driver.c b/drivers/staging/sep/sep_driver.c > index cf5c897..86e676d 100644 > --- a/drivers/staging/sep/sep_driver.c > +++ b/drivers/staging/sep/sep_driver.c > @@ -112,7 +112,7 @@ static int sep_load_firmware(struct sep_device *sep) > sep->resident_addr); > dev_dbg(&sep->pdev->dev, "residnet bus is %lx\n", > (unsigned long)sep->resident_bus); > - dev_dbg(&sep->pdev->dev, "resident size is %08x\n", > + dev_dbg(&sep->pdev->dev, "resident size is %08Zx\n", > sep->resident_size); > > /* set addresses for dcache (no loading needed) */ > @@ -146,7 +146,7 @@ static int sep_load_firmware(struct sep_device *sep) > sep->cache_addr); > dev_dbg(&sep->pdev->dev, "cache bus is %08lx\n", > (unsigned long)sep->cache_bus); > - dev_dbg(&sep->pdev->dev, "cache size is %08x\n", > + dev_dbg(&sep->pdev->dev, "cache size is %08Zx\n", > sep->cache_size); > > /* set addresses and load extapp */ > @@ -167,7 +167,7 @@ static int sep_load_firmware(struct sep_device *sep) > sep->extapp_addr); > dev_dbg(&sep->pdev->dev, "extapp bus is %08llx\n", > (unsigned long long)sep->extapp_bus); > - dev_dbg(&sep->pdev->dev, "extapp size is %08x\n", > + dev_dbg(&sep->pdev->dev, "extapp size is %08Zx\n", > sep->extapp_size); > > return error; > @@ -210,7 +210,7 @@ static int sep_map_and_alloc_shared_area(struct sep_device *sep) > return -ENOMEM; > } > dev_dbg(&sep->pdev->dev, > - "sep: shared_addr %x bytes @%p (bus %llx)\n", > + "sep: shared_addr %Zx bytes @%p (bus %llx)\n", > sep->shared_size, sep->shared_addr, > (unsigned long long)sep->shared_bus); > return 0; > @@ -3395,25 +3395,25 @@ static long sep_ioctl(struct file *filp, unsigned int cmd, unsigned long arg) > dev_dbg(&sep->pdev->dev, > "SEP_IOCSENDSEPCOMMAND is %x\n", SEP_IOCSENDSEPCOMMAND); > dev_dbg(&sep->pdev->dev, > - "SEP_IOCALLOCDATAPOLL is %x\n", SEP_IOCALLOCDATAPOLL); > + "SEP_IOCALLOCDATAPOLL is %lx\n", SEP_IOCALLOCDATAPOLL); > dev_dbg(&sep->pdev->dev, > - "SEP_IOCCREATESYMDMATABLE is %x\n", SEP_IOCCREATESYMDMATABLE); > + "SEP_IOCCREATESYMDMATABLE is %lx\n", SEP_IOCCREATESYMDMATABLE); > dev_dbg(&sep->pdev->dev, > "SEP_IOCFREEDMATABLEDATA is %x\n", SEP_IOCFREEDMATABLEDATA); > dev_dbg(&sep->pdev->dev, > "SEP_IOCSEPSTART is %x\n", SEP_IOCSEPSTART); > dev_dbg(&sep->pdev->dev, > - "SEP_IOCSEPINIT is %x\n", SEP_IOCSEPINIT); > + "SEP_IOCSEPINIT is %lx\n", SEP_IOCSEPINIT); > dev_dbg(&sep->pdev->dev, > - "SEP_IOCGETSTATICPOOLADDR is %x\n", SEP_IOCGETSTATICPOOLADDR); > + "SEP_IOCGETSTATICPOOLADDR is %lx\n", SEP_IOCGETSTATICPOOLADDR); > dev_dbg(&sep->pdev->dev, > "SEP_IOCENDTRANSACTION is %x\n", SEP_IOCENDTRANSACTION); > dev_dbg(&sep->pdev->dev, > - "SEP_IOCREALLOCEXTCACHE is %x\n", SEP_IOCREALLOCEXTCACHE); > + "SEP_IOCREALLOCEXTCACHE is %lx\n", SEP_IOCREALLOCEXTCACHE); > dev_dbg(&sep->pdev->dev, > - "SEP_IOCRARPREPAREMESSAGE is %x\n", SEP_IOCRARPREPAREMESSAGE); > + "SEP_IOCRARPREPAREMESSAGE is %lx\n", SEP_IOCRARPREPAREMESSAGE); > dev_dbg(&sep->pdev->dev, > - "SEP_IOCPREPAREDCB is %x\n", SEP_IOCPREPAREDCB); > + "SEP_IOCPREPAREDCB is %lx\n", SEP_IOCPREPAREDCB); > dev_dbg(&sep->pdev->dev, > "SEP_IOCFREEDCB is %x\n", SEP_IOCFREEDCB); > > @@ -3736,7 +3736,7 @@ static int sep_callback(unsigned long sep_context_pointer) > } > > dev_dbg(&sep->pdev->dev, "rar start is %p, phy is %llx," > - " size is %x\n", > + " size is %Zx\n", > sep->rar_addr, (unsigned long long)sep->rar_bus, > sep->rar_size); > > @@ -3864,7 +3864,7 @@ static int __devinit sep_probe(struct pci_dev *pdev, > } > > dev_dbg(&sep->pdev->dev, "rar start is %p, phy is %llx," > - " size is %x\n", sep->rar_addr, > + " size is %Zx\n", sep->rar_addr, > (unsigned long long)sep->rar_bus, > sep->rar_size); > } > -- --- ~Randy *** Remember to use Documentation/SubmitChecklist when testing your code *** -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists