linux-kernel - Re: [PATCH -v1.1] HPET: Fix HPET readout for small deltas

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.00.1011292322080.2900@localhost6.localdomain6>
Date:	Mon, 29 Nov 2010 23:36:05 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Borislav Petkov <bp@...64.org>
cc:	"a.p.zijlstra@...llo.nl" <a.p.zijlstra@...llo.nl>,
	john stultz <johnstul@...ibm.com>,
	"Herrmann3, Andreas" <Andreas.Herrmann3@....com>,
	"mtosatti@...hat.com" <mtosatti@...hat.com>,
	"heiko.carstens@...ibm.com" <heiko.carstens@...ibm.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Borislav Petkov <bp@...en8.de>,
	"avi@...hat.com" <avi@...hat.com>, Ingo Molnar <mingo@...e.hu>,
	"hpa@...ux.intel.com" <hpa@...ux.intel.com>,
	Markus Trippelsdorf <markus@...ppelsdorf.de>
Subject: Re: [PATCH -v1.1] HPET: Fix HPET readout for small deltas

On Mon, 29 Nov 2010, Borislav Petkov wrote:
>  
> +	/* Accept only sensible values written by BIOS */
> +	if (hpet_tbl->minimum_tick < hpet_min_tick)
> +		hpet_min_tick = hpet_tbl->minimum_tick;

I ran this through everything I could get hold of. And as I feared
when ACPI was mentioned in the first place, I found at least three
machines which have hpet_tbl->minimum_tick < 4. Two of those failed to
boot.

This is all doomed to fail. 

1) ACPI's trustworthiness aproaches ZERO

2) The chipset manufactures who implement the "HPET spec" are even
   worse. They could tell us the exact number of cycles which are
   necessary to make these "specificatin compliant" trainwrecks
   functional, but all we get is a reference to #1.

Crap. If you don't come up with some real facts, I'm simply going to
commit

diff --git a/arch/x86/kernel/hpet.c b/arch/x86/kernel/hpet.c
index ae03cab..0388a70 100644
--- a/arch/x86/kernel/hpet.c
+++ b/arch/x86/kernel/hpet.c
@@ -408,7 +408,7 @@ static int hpet_next_event(unsigned long delta,
 	 */
 	res = (s32)(cnt - hpet_readl(HPET_COUNTER));
 
-	return res < 8 ? -ETIME : 0;
+	return res < 128 ? -ETIME : 0;
 }
 
 static void hpet_legacy_set_mode(enum clock_event_mode mode,

along with the corresponding fix for the min_delta_ns value.

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/