| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Mon, 29 Nov 2010 23:41:27 +0100 From: Felix Fietkau <nbd@...nwrt.org> To: peter@...ge.se CC: ath9k-devel@...ts.ath9k.org, linux-kernel@...r.kernel.org, "Luis R. Rodriguez" <lrodriguez@...eros.com>, linux-wireless <linux-wireless@...r.kernel.org> Subject: Re: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug On 2010-11-29 7:07 AM, Peter Stuge wrote: > Luis R. Rodriguez wrote: >> On Sun, Nov 28, 2010 at 3:53 PM, Joe Perches <joe@...ches.com> wrote: >> > Make the function name match the function purpose. >> > ath_debug is a debug only facility. >> > ath_print seems too generic a name for a debug only use. >> >> Nack, I don't see the point. > > The point is to improve readability. I like the patch. And how exactly does this improve readability? Don't get me wrong, I generally like to see more cleanups merged to the ath/ath9k drivers (they do need it, after all). But in my opinion, simple renaming churn like this does nothing but annoy people who want to get other work done at the same time. Consider the large number of lines touched (and the potential merge conflicts with other code because of that), relative to the microscopic aesthetic gain (if any). Instead I'd like to see more cleanups that go beyond trivial function renames. - Felix -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists