linux-kernel - Re: [PATCH] Repalce strncmp by memcmp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4CF42E07.40207@pavlinux.ru>
Date:	Tue, 30 Nov 2010 01:49:43 +0300
From:	Pavel Vasilyev <pavel@...linux.ru>
To:	Steven Rostedt <rostedt@...dmis.org>
CC:	LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] Repalce strncmp by memcmp

On 30.11.2010 01:26, Steven Rostedt wrote:
> On Mon, 2010-11-29 at 17:18 -0500, Steven Rostedt wrote:
>
>> Um, do you realize that the kernel does not always use the same memcmp
>> as gcc.
>>
> Note, I'm not against the change, because in 99% of the cases, memcmp()
> can and will be faster, and we don't need to worry about these strange
> cases.
>
> What I'm against is a blind s/strncmp/memcmp/ of the kernel, because it
> may have side effects that you may not have thought of.
>
Then we have to hang a large banner that is visible to all developers.
"Change wherever possible strncmp to memcmp," :)

-- 

                                                         Pavel.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/