linux-kernel - RE: [PATCH] net/r8169: Correct the ram code for RTL8111D(L)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 29 Nov 2010 11:47:07 +0800
From:	hayeswang <hayeswang@...ltek.com>
To:	'Ben Hutchings' <benh@...ian.org>,
	'Francois Romieu' <romieu@...zoreil.com>
CC:	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	'David Miller' <davem@...emloft.net>, <564628@...s.debian.org>
Subject: RE: [PATCH] net/r8169: Correct the ram code for RTL8111D(L)

Excuse me, I have some questions about the firmware patch.

1. I should convert the data into the binary files (.bin). Is it right?

2. Where should I update the firmware files? Is the path the
linux-2.6/firmeware?
    However, according to linux-2.6/firmeware/README.AddingFirmware, I
should
    update they to another repository:

	
git://git.kernel.org/pub/scm/linux/kernel/git/dwmw2/linux-firmware.git

    Then, how the firmware merge with kernel-2.6? Or, where could I find the
firmware
    in the kernel-2.6 repository?
 
Best Regards,
Hayes


> -----Original Message-----
> From: Ben Hutchings [mailto:benh@...ian.org] 
> Sent: Saturday, November 27, 2010 7:12 AM
> To: Francois Romieu; Hayeswang
> Cc: netdev@...r.kernel.org; linux-kernel@...r.kernel.org; 
> David Miller; 564628@...s.debian.org
> Subject: Re: [PATCH] net/r8169: Correct the ram code for RTL8111D(L)
> 
> On Fri, 2010-11-26 at 23:49 +0100, Francois Romieu wrote:
> > Ben Hutchings <benh@...ian.org> :
> > > On Fri, 2010-11-26 at 19:54 +0800, Hayes Wang wrote:
> > > > Correct the binary code (Low pass filter & DLY_CAP fine 
> tune from uC).
> > > > The incorrect ram code would make the nic working abnormally.
> > > [...]
> > > 
> > > I'm glad you finally acknowledge that this is code rather than 
> > > simple register initialisation.
> > 
> > I am not sure that Hayes is a native english speaker.
> > 
> > I am glad to see him posting here.
> 
> Right.
> 
> Hayes, by 'you' I meant Realtek, not you personally.  If my 
> reply seemed aggressive, I apologise.
> 
> > [...]
> > > Below are the changes Debian currently applies in preparation for 
> > > proper licencing of the firmware.
> > 
> > Do you have some scripts to convert the data at hand ?
> [...]
> 
> No, it's easy enough to convert a single array by copying it 
> into a C file that dumps it to stdout (assuming the file's 
> byte order is defined to match your own machine).
> 
> It might be worth adding some sort of header with a version 
> and checksum.  Your choice, really.
> 
> Ben.
> 
> --
> Ben Hutchings, Debian Developer and kernel team member
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/