linux-kernel - Re: [PATCH] arm: plat-spear: time: use IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <AANLkTi==K=pYU-x5ZQQ9ACLD-MN8o9N61JbVqpBZnQWT@mail.gmail.com>
Date:	Mon, 29 Nov 2010 12:02:08 +0530
From:	viresh kumar <viresh.linux@...il.com>
To:	Vasiliy Kulikov <segoon@...nwall.com>
Cc:	kernel-janitors@...r.kernel.org,
	Viresh Kumar <viresh.kumar@...com>,
	Russell King <linux@....linux.org.uk>,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Shiraz HASHIM <shiraz.hashim@...com>
Subject: Re: [PATCH] arm: plat-spear: time: use IS_ERR() instead of NULL check

On Fri, Nov 26, 2010 at 10:36 PM, Vasiliy Kulikov <segoon@...nwall.com> wrote:
> clk_get() returns ERR_PTR() on error, not NULL.
>
> Signed-off-by: Vasiliy Kulikov <segoon@...nwall.com>
> ---
>  Cannot compile this driver, so it is not tested at all.
>
>  arch/arm/plat-spear/time.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm/plat-spear/time.c b/arch/arm/plat-spear/time.c
> index ab21165..678df18 100644
> --- a/arch/arm/plat-spear/time.c
> +++ b/arch/arm/plat-spear/time.c
> @@ -229,13 +229,13 @@ void __init spear_setup_timer(void)
>        }
>
>        gpt_clk = clk_get_sys("gpt0", NULL);
> -       if (!gpt_clk) {
> +       if (IS_ERR(gpt_clk)) {
>                pr_err("%s:couldn't get clk for gpt\n", __func__);
>                goto err_iomap;
>        }
>
>        pll3_clk = clk_get(NULL, "pll3_48m_clk");
> -       if (!pll3_clk) {
> +       if (IS_ERR(pll3_clk)) {
>                pr_err("%s:couldn't get PLL3 as parent for gpt\n", __func__);
>                goto err_iomap;
>        }

Compiled & tested.

Acked-by: Viresh Kumar <viresh.kumar@...com>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/