linux-kernel - Re: [PATCH] Input: Lenovo S10-3t's touchpad support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5hfwujp9nf.wl%tiwai@suse.de>
Date:	Tue, 30 Nov 2010 08:12:36 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	"Li, Yan I" <yan.i.li@...el.com>
Cc:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"Ding, Jian-feng" <jian-feng.ding@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"meego-kernel@...ts.meego.com" <meego-kernel@...ts.meego.com>,
	Christopher Heiny <christopherheiny@...il.com>
Subject: Re: [PATCH] Input: Lenovo S10-3t's touchpad support

At Tue, 30 Nov 2010 10:18:40 +0800,
Li, Yan I wrote:
> 
> On Sat, Nov 27, 2010 at 03:55:28PM +0800, Dmitry Torokhov wrote:
> > > So far we've found that the S10-3ts are shipped with two slightly
> > > different models of touchpads, of which the 0x0c cap is either
> > > 0x5a0400 or 0x4a0500. They are not Clickpad and return BTN_LEFT and
> > > BTN_RIGHT normally.
> > 
> > Hmm, this is weird. According to my data:
> > 
> > >> Treat it as a two-bit field.
> > >>   0x00 == not a clickpad
> > >>   0x01 == 1 button clickpad
> > >>   0x02 == 2 button clickpad
> > >>   0x03 == reserved
> 
> Wait, you said there are "2 button clickpad"? If so the current way
> the kernel handles clickpad is totally wrong:
> 
>     if (SYN_CAP_CLICKPAD(priv->ext_cap_0c)) {
>         /* Clickpads report only left button */
>         __clear_bit(BTN_RIGHT, dev->keybit);
>         __clear_bit(BTN_MIDDLE, dev->keybit);
>     }
> 
> It could only handle those "1 button clickpad", which emits solely
> BTN_MIDDLE (and the kernel sends it out as BTN_LEFT instead). It can't
> handle "2 button clickpad" correctly.

The "normal" clickpad also reports that bit.  I don't see any
difference between Lenovo and HP machines wrt caps values.
It shows the exact same numbers below:

Synaptics Touchpad, model: 1, fw: 7.4, id: 0x1e0b1, caps:
0xd04771/0xe40000/0x5a0400


Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/