linux-kernel - Re: [PATCH] genirq: fix incorrect proc spurious output

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 30 Nov 2010 12:07:42 +0200
From:	Alexey Dobriyan <adobriyan@...il.com>
To:	Yong Zhang <yong.zhang0@...il.com>
Cc:	Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>,
	tglx@...utronix.de, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] genirq: fix incorrect proc spurious output

On Tue, Nov 30, 2010 at 05:08:13PM +0800, Yong Zhang wrote:
> 2010/11/30 Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>:
> > Fix the problem that all the /proc/irq/XX/spurious files shows the IRQ
> > 0 information.
> >
> > Current irq_spurious_proc_open() passes on NULL as the 3rd argument,
> > which is used as an IRQ number in irq_spurious_proc_show(), to the
> > single_open(). Because of this, all the /proc/irq/XX/spurious file
> > shows IRQ 0 information regardless of the IRQ number.
> >
> > To fix the problem, irq_spurious_proc_open() must pass on the
> > appropreate data (IRQ number) to single_open().
> >
> > Signed-off-by: Kenji Kaneshige <kaneshige.kenji@...fujitsu.com>
> 
> Looks good.
> 
> Reviewed-by: Yong Zhang <yong.zhang0@...il.com>
> 
> BTW, it's introduced by a1afb6371bb5341057056194d1168753f6d77242
> So should we Cc'ing stable?

Definitely.

> >  static int irq_spurious_proc_open(struct inode *inode, struct file *file)
> >  {
> > -       return single_open(file, irq_spurious_proc_show, NULL);
> > +       return single_open(file, irq_spurious_proc_show, PDE(inode)->data);
> >  }
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/