linux-kernel - Re: 5ada28bf76752 causes compilation error if !CONFIG_LEDS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20101130112525.GA9639@elte.hu>
Date:	Tue, 30 Nov 2010 12:25:25 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	Johannes Berg <johannes@...solutions.net>,
	Arnd Hannemann <arnd@...dnet.de>,
	Michal Hocko <mhocko@...e.cz>,
	LKML <linux-kernel@...r.kernel.org>,
	Richard Purdie <rpurdie@...ux.intel.com>,
	Randy Dunlap <randy.dunlap@...cle.com>
Subject: Re: 5ada28bf76752 causes compilation error if !CONFIG_LEDS_CLASS


* Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Tue, 23 Nov 2010 10:41:30 +0100
> Johannes Berg <johannes@...solutions.net> wrote:
> 
> > On Tue, 2010-11-23 at 09:17 +0000, Ingo Molnar wrote:
> > 
> > > It fails to build on x86 64-bit allmodconfig:
> > 
> > Let's not modify them to tristate then, too many ifdefs.
> > 
> > johannes
> > 
> > 
> > Subject: leds: fix up dependencies
> > From: Johannes Berg <johannes.berg@...el.com>
> > 
> > It's not useful to build LED triggers when
> > there's no LEDs that can be triggered by
> > them. Therefore, fix up the dependencies
> > so that this cannot happen, and fix a few
> > users that select triggers to depend on
> > LEDS_CLASS as well (there is also one user
> > that also selects LEDS_CLASS, which is OK).
> 
> Ingo, Randy: does this work for you?

Yes, it does, havent seen a leds build failure for some time.

Tested-by: Ingo Molnar <mingo@...e.hu>

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/