linux-kernel - Re: [PATCH v1.5 3/5] key: add tpm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1291130566.2737.29.camel@localhost.localdomain>
Date:	Tue, 30 Nov 2010 10:22:46 -0500
From:	David Safford <safford@...son.ibm.com>
To:	David Howells <dhowells@...hat.com>
Cc:	kjhall@...ibm.com, Serge Hallyn <serge.hallyn@...onical.com>,
	Mimi Zohar <zohar@...ux.vnet.ibm.com>,
	tpmdd-devel@...ts.sourceforge.net, linux-kernel@...r.kernel.org,
	linux-security-module@...r.kernel.org, keyrings@...ux-nfs.org,
	linux-crypto@...r.kernel.org,
	Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
	James Morris <jmorris@...ei.org>,
	Rajiv Andrade <srajiv@...ux.vnet.ibm.com>
Subject: Re: [PATCH v1.5 3/5] key: add tpm_send command

On Tue, 2010-11-30 at 14:32 +0000, David Howells wrote:
> Serge Hallyn <serge.hallyn@...onical.com> wrote:
> 
> > > +int tpm_send(u32 chip_num, void *cmd, size_t buflen)
> > 
> > Hate to nit-pick, but any particular reason you're not following the
> > rest of the file and using 'struct tpm_cmd_t *cmd' here?
> 
> Ummm...  Something else I've just noticed...
> 
> 	static ssize_t tpm_transmit(struct tpm_chip *chip, const char *buf,
> 					       size_t bufsiz)
> 
> would suggest that buf is read-only, but tpm_transit() keeps casting it away,
> and especially, casts it away before passing it to chip->vendor.recv()...
> This would seem to indicate a logic error somewhere.
> 
> Certainly, tpm_atml_recv() modifies the buffer it is given to...

as does tpm_tis_recv(). By the TCG spec, the return data should go in the
same input buffer.

> I suspect the argument and reply buffer pointers should be passed separately.

It seems more like a spurious "const" in tpm_transmit(). This has been in the
code for a long time. Good catch. I'll draft a cleanup for these and some
other nits and send to Rajiv...

thanks!
dave

> David
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/