linux-kernel - Re: PATCH V4 1/2] input: CMA3000 Accelerometer Driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4CF52EF1.3050000@cam.ac.uk>
Date:	Tue, 30 Nov 2010 17:05:53 +0000
From:	Jonathan Cameron <jic23@....ac.uk>
To:	Hemanth V <hemanthv@...com>
CC:	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-omap@...r.kernel.org, saaguirre@...com, Shubhrajyoti@...com
Subject: Re: PATCH V4 1/2] input: CMA3000 Accelerometer Driver

On 11/30/10 12:50, Hemanth V wrote:
> ----- Original Message ----- From: "Dmitry Torokhov" <dmitry.torokhov@...il.com>
>>
>> Yep, almost there.
>>
>> Hemanth, does the driver still work if you apply the patch below?
> 
> Yes works pretty well, Thanks for your efforts
> 
> Some minor changes as below required.
> 
> <snip>
> 
>> +struct cma3000_accl_data {
>> + const struct cma3000_bus_ops *bus_ops;
>> + const struct cma3000_platform_data *pdata;
>> +
>> + struct device *dev;
>> + struct input_dev *input_dev;
>> +
>> + int bit_to_mg;
>> + int irq;
>> +
>> + int g_range;
>> + u8 mode;
>> +
>> + struct mutex mutex;
> 
> Need a comment to overcome checkpatch warning.
> 
>>
>> - pr_info("CMA3000 Accelerometer : Revision %x\n", ret);
>> + data->dev = dev;
>> + data->input_dev = input_dev;
>> + data->bus_ops = bops;
>> + data->pdata = pdata;
> 
> Need to add data->irq = irq, else exit routine will dump stack
> 
>>
>> - data->input_dev->name = "cma3000-accelerometer";
>> + data->g_range = pdata->g_range;
>> + if (data->g_range != CMARANGE_2G && data->g_range != CMA3000_RANGE8G) {
> 
> Need to change this to "data->g_range != CMARANGE_2G   && data->g_range != CMARANGE_8G "
> 
>> - input_set_abs_params(data->input_dev, ABS_Z, -g_range,
>> - g_range, fuzz_z, 0);
>> - input_set_abs_params(data->input_dev, ABS_MISC, 0,
>> - 1, 0, 0);
> 
> We use this ABS_MISC event to report free fall.
Free fall isn't a conventional user input...  The lis3 driver
and similar (currently hiding in hwmon)
handle this via a separately registered chrdev.  It might not
be the best plan, but it is an existing interface so we need to
involve them in any discussion if you want to change it.


> 
> 
> 
> 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/