| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20101130174052.GA19977@kroah.com> Date: Tue, 30 Nov 2010 09:40:52 -0800 From: Greg KH <greg@...ah.com> To: Ben Hutchings <bhutchings@...arflare.com> Cc: erazor_de@...rs.sourceforge.net, Randy Dunlap <rdunlap@...otime.net>, Greg Kroah-Hartman <gregkh@...e.de>, Jiri Kosina <jkosina@...e.cz>, linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org, linux-input@...r.kernel.org, netdev@...r.kernel.org Subject: Re: [PATCH 3/5] HID: roccat: declaring meaning of pack pragma usage in driver headers On Fri, Nov 26, 2010 at 08:50:16PM +0000, Ben Hutchings wrote: > On Fri, 2010-11-26 at 20:57 +0100, Stefan Achatz wrote: > > Using pack pragma to prevent padding bytes in binary data structures > > used for hardware communication. Explanation of these pragmas was requested. > [...] > > It would be clearer to use the '__packed' macro after each structure > definition instead of using this awful Microsoft extension. I agree, that's the "normal" Linux way of doing things. Other than that, this patch set looks good to me. Jiri, if the packed change is made, do you want me to take these through my tree, or do you want to take them through yours? Whatever is easier for you is fine with me. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists