linux-kernel - Re: [2/8, v5] NUMA Hotplug Emulator: Add node hotplug emulation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.00.1011301208060.12979@chino.kir.corp.google.com>
Date:	Tue, 30 Nov 2010 12:10:09 -0800 (PST)
From:	David Rientjes <rientjes@...gle.com>
To:	Shaohui Zheng <shaohui.zheng@...el.com>
cc:	akpm@...ux-foundation.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, haicheng.li@...ux.intel.com,
	lethal@...ux-sh.org, ak@...ux.intel.com,
	shaohui.zheng@...ux.intel.com, dave@...ux.vnet.ibm.com,
	gregkh@...e.de, Haicheng Li <haicheng.li@...el.com>
Subject: Re: [2/8, v5] NUMA Hotplug Emulator: Add node hotplug emulation

On Tue, 30 Nov 2010, Shaohui Zheng wrote:

> We have two memory hotplug interfaces here:
> add_node: add a new NUMA node
> probe: add memory section
> 
> so puting add_node to node/add_node and puting probe to memory/probe should make sense. 
> it is similar with sysfs hierarchy.
> 
> if we want to move the add_node to mem_hotplug/add_node, I'd prefer to put the probe
> interface to mem_hotplug/probe since they are also related to memory hotplug.
> 
> I will include this change in next patchset.
> 

No, please don't move the 'probe' trigger to debugfs; hotadding memory 
should not depend on CONFIG_DEBUG_FS.  Node hotplug emulation _is_ a 
debugging function and can therefore be defined in debugfs as I did but 
with a s/hotplug/mem_hotplug change that Greg suggested.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/