linux-kernel - Re: [PATCH 8/8] Add yaffs2 file system: VFS glue code, hook into kernel tree building

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTi=SXnSowvzm3Mu-1357HSzBTuBcrUBuwpN04sFH@mail.gmail.com>
Date:	Wed, 1 Dec 2010 16:30:32 +1100
From:	Nick Piggin <npiggin@...il.com>
To:	Charles Manning <cdhmanning@...il.com>
Cc:	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 8/8] Add yaffs2 file system: VFS glue code, hook into
 kernel tree building

On Wed, Dec 1, 2010 at 8:57 AM, Charles Manning <cdhmanning@...il.com> wrote:

> +#define UnlockPage(p) unlock_page(p)
> +#define Page_Uptodate(page)    test_bit(PG_uptodate, &(page)->flags)

You should never be testing page flags by hand, outside mm code.

Why aren't you using PageUptodate()?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/