linux-kernel - Re: [PATCH v2] Input: Bug 18122 - Support Lenovo S10-3t's 2-button ClickPad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <s5heia2ni58.wl%tiwai@suse.de>
Date:	Wed, 01 Dec 2010 07:04:19 +0100
From:	Takashi Iwai <tiwai@...e.de>
To:	"Li, Yan I" <yan.i.li@...el.com>
Cc:	Tobyn Bertram <tobynbertram@...mail.com>,
	'Dmitry Torokhov' <dmitry.torokhov@...il.com>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"Ding, Jian-feng" <jian-feng.ding@...el.com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"meego-kernel@...ts.meego.com" <meego-kernel@...ts.meego.com>
Subject: Re: [PATCH v2] Input: Bug 18122 - Support Lenovo S10-3t's 2-button ClickPad

At Wed, 1 Dec 2010 12:11:04 +0800,
Li, Yan I wrote:
> 
> On Tue, Nov 30, 2010 at 11:48:12PM +0800, Tobyn Bertram wrote:
> > I do not have a S10-3t.  I have a HP DV7t with a standard 1 button Clickpad.
> > I am sorry for any confusion.
> 
> Thank you. This clarify the S10-3t touchpad mystery. So I think my v2
> patch is valid.
> 
> > I think that 2 different Clickpads will need to be defined: 1 button
> > Clickpads and 2 button Clickpads.  Maybe like this?
> > 
> > #define SYN_CAP_CLICKPAD1BTN(ex0c)		((ex0c) & 0x100000)
> > #define SYN_CAP_CLICKPAD2BTN(ex0c)		((ex0c) & 0x000100)
> 
> Maybe, although we don't have any code that needs
> SYN_CAP_CLICKPAD2BTN() so far, only 1-button clickpad needs special
> handling, but it's good to have a more precise name.

Agreed.  Also, it's interesting to see how 2-button clickpad devices 
behave in multi-touch mode...


thanks,

Takashi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/