linux-kernel - Re: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <AANLkTinuVWuiVpKrz_oEAFKt6Hgxu4kU13iKthj8E0m1@mail.gmail.com>
Date:	Tue, 30 Nov 2010 23:59:15 -0800
From:	"Luis R. Rodriguez" <mcgrof@...il.com>
To:	Joe Perches <joe@...ches.com>
Cc:	Felix Fietkau <nbd@...nwrt.org>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	ath9k-devel@...ts.ath9k.org, peter@...ge.se,
	linux-kernel@...r.kernel.org
Subject: Re: [ath9k-devel] [PATCH wireless-next] ath: Rename ath_print to ath_debug

On Tue, Nov 30, 2010 at 11:56 PM, Luis R. Rodriguez <mcgrof@...il.com> wrote:
> On Tue, Nov 30, 2010 at 12:19 PM, Joe Perches <joe@...ches.com> wrote:
>> On Tue, 2010-11-30 at 03:43 +0100, Felix Fietkau wrote:
>>> On 2010-11-30 2:39 AM, Joe Perches wrote:
>>> > I gauge my willingness to spend time on subsystems on
>>> > the maintainers willingness to merge things that improve
>>> > readability and correctness.
>>> I'm not trying to discourage you from spending time on improving this
>>> code, just doubting the usefulness of such simple function renames.
>>
>> Poor function naming is just that.
>> It reduces readability and the uses are counter expectation.
>
> The name is perfect, we use it to print anything, even non-debugging stuff.

If you are writing trivial patches please be ready to accept trivial
NACKs for them as well. IMHO its best if the large diffstat trivial
patches had more purpose than just scratch a small tiny itch.

  Luis
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/